Re: [PATCH] dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key

From: patchwork-bot+netdevbpf
Date: Tue Feb 15 2022 - 09:40:22 EST


Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Mon, 14 Feb 2022 07:41:39 -0800 you wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> Clang static analysis reports this representative problem
> dpaa2-switch-flower.c:616:24: warning: The right operand of '=='
> is a garbage value
> tmp->cfg.vlan_id == vlan) {
> ^ ~~~~
> vlan is set in dpaa2_switch_flower_parse_mirror_key(). However
> this function can return success without setting vlan. So
> change the default return to -EOPNOTSUPP.
>
> [...]

Here is the summary with links:
- dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key
https://git.kernel.org/netdev/net/c/2a36ed7c1cd5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html