Re: [PATCH v2] usb: gadget: f_uvc: fix superspeedplus transfer

From: Greg KH
Date: Tue Feb 15 2022 - 09:07:09 EST


On Tue, Feb 15, 2022 at 10:16:47AM +0800, 3090101217@xxxxxxxxxx wrote:
> From: Jing Leng <jleng@xxxxxxxxxxxxx>
>
> UVC driver doesn't set ssp_descriptors in struct usb_function,
> If UVC uses superspeedplus UDC (e.g. cdnsp), when
> config_ep_by_speed_and_alt is called, the g->speed is
> USB_SPEED_SUPER_PLUS, and f->ssp_descriptors is NULL,
> So kernel will access NULL pointer of speed_desc.
>
> Call trace:
> config_ep_by_speed_and_alt+0x3c/0x2a0 [libcomposite]
> uvc_function_set_alt+0xd4/0x2e8 [usb_f_uvc]
> set_config.constprop.0+0x154/0x3a0 [libcomposite]
> composite_setup+0x314/0xb44 [libcomposite]
> configfs_composite_setup+0x84/0xb0 [libcomposite]
> cdnsp_ep0_std_request+0x25c/0x470 [cdns3]
> cdnsp_setup_analyze+0x94/0x25c [cdns3]
> cdnsp_handle_event+0xe8/0x23c [cdns3]
> cdnsp_thread_irq_handler+0x58/0xe8 [cdns3]
> irq_thread_fn+0x2c/0xa0
> irq_thread+0x164/0x280
> kthread+0x128/0x134
> ret_from_fork+0x10/0x40

What does "call trace" here mean? Is this an error? Something else?

>
> Signed-off-by: Jing Leng <jleng@xxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/function/f_uvc.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)

You did not read the information that my bot told you to read, for how
to properly version your patches :(

Please go back and do so when you resend all of them.

Also this is not a patch series? Why not?

thanks,

greg k-h