Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id

From: Nestor Lopez Casado
Date: Tue Feb 15 2022 - 04:01:15 EST


On Wed, Jan 26, 2022 at 3:55 PM Filipe Laíns <lains@xxxxxxxxxx> wrote:
>
> On Wed, 2022-01-26 at 15:47 +0100, Benjamin Tissoires wrote:
> > On Wed, Jan 26, 2022 at 3:44 PM Lucas Zampieri <lzampier@xxxxxxxxxx> wrote:
> > >
> > > As of logitech lightspeed receiver fw version 04.02.B0009,
> > > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > >
> > > With patch "HID: logitech-dj: add support for the new lightspeed receiver
> > > iteration", the mouse starts to error out with:
> > > logitech-djreceiver: unusable device of type UNKNOWN (0x011) connected on
> > > slot 1
> > > and becomes unusable.
> > >
> > > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B0018.
> >
> > The patch looks good to me.
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> >
> > Ideally, Nestor, can you confirm this is expected and that we won't
> > have any bad surprises there?
Yes, I confirm this matches our specifications, this is an iteration
of Lightspeed 1.2
No objections on my side.

> >
> > I think we probably want this to be Cc-ed to stable once it gets
> > merged (we can add the tag as we merge it).
> >
> > Cheers,
> > Benjamin
>
> This is likely a different connection type, so it should probably get its own
> case statement, but let's let Nestor confirm :)
>
> Cheers,
> Filipe Laíns
best,
-nestor