Re: [PATCH v2 1/2] usb: dwc3: Not set DWC3_EP_END_TRANSFER_PENDING in ep cmd fails

From: Greg Kroah-Hartman
Date: Tue Feb 15 2022 - 02:37:22 EST


On Tue, Feb 15, 2022 at 03:58:26PM +0900, Jung Daehwan wrote:
> On Mon, Feb 14, 2022 at 12:29:49PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Feb 14, 2022 at 08:08:52PM +0900, Daehwan Jung wrote:
> > > It always sets DWC3_EP_END_TRANSFER_PENDING in dwc3_stop_active_transfer
> > > even if dwc3_send_gadget_ep_cmd fails. It can cause some problems like
> > > skipping clear stall commmand or giveback from dequeue. We fix to set it
> > > only when ep cmd success. Additionally, We clear DWC3_EP_TRANSFER_STARTED
> > > for next trb to start transfer not update transfer.
> >
> > So is this two different changes?
> >
> > >
> > > Signed-off-by: Daehwan Jung <dh10.jung@xxxxxxxxxxx>
> >
> > What commit id does this fix?
> >
> > thanks,
> >
> > greg k-h
> >
>
> Hi greg,
>
> Below is commit id to fix.
>
> commit c58d8bfc77a2c7f6ff6339b58c9fca7ae6f57e70
> Author: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> Date: Wed Dec 18 18:14:44 2019 -0800

<snip>

Then please properly put that as a "Fixes:" tag in the signed-off-by
area when you resubmit this.

thanks,

greg k-h