Re: [PATCH v2] ath5k: use swap() to make code cleaner

From: Luis Chamberlain
Date: Tue Feb 15 2022 - 02:25:53 EST


On Tue, Feb 15, 2022 at 10:31:34AM +0800, davidcomponentone@xxxxxxxxx wrote:
> From: Yang Guang <yang.guang5@xxxxxxxxxx>
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Yang Guang <yang.guang5@xxxxxxxxxx>
> Signed-off-by: David Yang <davidcomponentone@xxxxxxxxx>
> ---

Sorry I don't trust your code as you submitted an incorrect patch last
time. So unless we get a Tested-by that there is no regression I can't
say this is correct. Please fix Zeal Robot, or better yet, open source
it for peer review.

Luis