Re: [PATCH] ata: add/use ata_taskfile::{error|status} fields
From: kernel test robot
Date: Mon Feb 14 2022 - 23:08:01 EST
Hi Sergey,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc4 next-20220214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sergey-Shtylyov/ata-add-use-ata_taskfile-error-status-fields/20220215-044836
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d567f5db412ed52de0b3b3efca4a451263de6108
config: ia64-defconfig (https://download.01.org/0day-ci/archive/20220215/202202151114.obEATTFy-lkp@xxxxxxxxx/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5d89e7cd8ab42fd2cb6f59a7922784b0cce835bf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sergey-Shtylyov/ata-add-use-ata_taskfile-error-status-fields/20220215-044836
git checkout 5d89e7cd8ab42fd2cb6f59a7922784b0cce835bf
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/ata/sata_vsc.c: In function 'vsc_sata_tf_read':
>> drivers/ata/sata_vsc.c:203:35: error: 'feature' undeclared (first use in this function)
203 | tf->hob_feature = feature >> 8;
| ^~~~~~~
drivers/ata/sata_vsc.c:203:35: note: each undeclared identifier is reported only once for each function it appears in
vim +/feature +203 drivers/ata/sata_vsc.c
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 181
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 182
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 183 static void vsc_sata_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 184 {
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 185 struct ata_ioports *ioaddr = &ap->ioaddr;
5d89e7cd8ab42fd drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 186 u16 nsect, lbal, lbam, lbah, error;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 187
5d89e7cd8ab42fd drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 188 tf->status = ata_sff_check_status(ap);
0d5ff566779f894 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 189 tf->device = readw(ioaddr->device_addr);
5d89e7cd8ab42fd drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 190 error = readw(ioaddr->error_addr);
0d5ff566779f894 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 191 nsect = readw(ioaddr->nsect_addr);
0d5ff566779f894 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 192 lbal = readw(ioaddr->lbal_addr);
0d5ff566779f894 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 193 lbam = readw(ioaddr->lbam_addr);
0d5ff566779f894 drivers/ata/sata_vsc.c Tejun Heo 2007-02-01 194 lbah = readw(ioaddr->lbah_addr);
ac19bff25b6834d drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 195
5d89e7cd8ab42fd drivers/ata/sata_vsc.c Sergey Shtylyov 2022-02-14 196 tf->error = error;
ac19bff25b6834d drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 197 tf->nsect = nsect;
ac19bff25b6834d drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 198 tf->lbal = lbal;
ac19bff25b6834d drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 199 tf->lbam = lbam;
ac19bff25b6834d drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 200 tf->lbah = lbah;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 201
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 202 if (tf->flags & ATA_TFLAG_LBA48) {
ac19bff25b6834d drivers/scsi/sata_vsc.c Jeff Garzik 2005-10-29 @203 tf->hob_feature = feature >> 8;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 204 tf->hob_nsect = nsect >> 8;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 205 tf->hob_lbal = lbal >> 8;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 206 tf->hob_lbam = lbam >> 8;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 207 tf->hob_lbah = lbah >> 8;
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 208 }
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 209 }
^1da177e4c3f415 drivers/scsi/sata_vsc.c Linus Torvalds 2005-04-16 210
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx