Re: [PATCH V2] selftests: Use -isystem instead of -I to include headers

[Shuah Khan]

On 2/14/22 12:25 PM, Kees Cook wrote:
> On Mon, Feb 14, 2022 at 09:07:56PM +0500, Muhammad Usama Anjum wrote:
> > Selftests need kernel headers and glibc for compilation. In compilation
> > of selftests, uapi headers from kernel source are used instead of
> > default ones while glibc has already been compiled with different header
> > files installed in the operating system. So there can be redefination

Spelling - redefinition

> > warnings from compiler. These warnings can be suppressed by using
> > -isystem to include the uapi headers.
> >
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Looks good to me. With the above minor type fixed:

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

This one depends on an earlier patch that added that added KHDR_INCLUDES
which is in Andrew's

https://ozlabs.org/~akpm/mmotm/broken-out/selftests-add-and-export-a-kernel-uapi-headers-path.patch

Andrew, would you like to take this through your tree?

thanks,
-- Shuah

Would you like to apply this on top of th