Re: [GIT PULL] sched/urgent for 5.17-rc4

[Tejun Heo]

On Mon, Feb 14, 2022 at 08:35:54PM +0100, Peter Zijlstra wrote:
> So there's two things that need doing; the re-cloning of the task_group
> thing, but also calling of __set_task_cpu() which sets up the proper
> runqueue links.
> 
> The first is CGroup only, and *could* in theory be done in ->can_fork(),
> but the second needs to be done unconditionally, and it doesn't make
> much sense to split this up.
> 
> I actually tried, but it made the patch bigger/uglier -- but maybe I
> didn't try hard enough.

If there needs to be a separate call anyway, it prolly is better to keep
them together. It'd just be nice to mention why cpu is different in this
regard in a comment.

Thanks.

-- 
tejun