Re: [PATCH v2] sh: avoid using IRQ0 on SH3/4

From: Geert Uytterhoeven
Date: Mon Feb 14 2022 - 06:27:55 EST


Hi Sergey,

On Mon, Feb 14, 2022 at 9:32 AM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:
> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
> and the code supporting SH3/4 SoCs maps the IRQ #s starting at 0 -- modify
> that code to start the IRQ #s from 16 instead.
>
> [1] https://lore.kernel.org/all/5e001ec1-d3f1-bcb8-7f30-a6301fd9930c@xxxxxx/
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> ---
> The patch is against Linus Torvalds' 'linux.git' repo.
>
> Changes in version 2:
> - changed cmp/ge to cmp/hs in the assembly code.

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Works fine on rts7751r2d (qemu) and landisk (real).
None of them had IRQ0, though, but dmesg and /proc/interrupts
confirm the shift by 16.
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds