Re: [PATCH v2 1/3] HID: apple: Add support for keyboard backlight on certain T2 Macs.

[Jiri Kosina]

On Thu, 3 Feb 2022, Aditya Garg wrote:

> 
> 
> > On 24-Jan-2022, at 8:38 PM, Aditya Garg <gargaditya08@xxxxxxxx> wrote:
> > 
> > From: Paul Pawlowski <paul@xxxxxxxx>
> > 
> > This patch introduces the requisite plumbing for supporting keyboard
> > backlight on T2-attached, USB exposed models. The quirk mechanism was
> > used to reuse the existing hid-apple driver.
> > 
> > Signed-off-by: Paul Pawlowski <paul@xxxxxxxx>
> > Signed-off-by: Aun-Ali Zaidi <admin@xxxxxxxxxx>
> > Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
> > ---
> > drivers/hid/hid-apple.c | 125 ++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 125 insertions(+)
> > 
> > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> > index 24802a4a6..c22d445a9 100644
> > --- a/drivers/hid/hid-apple.c
> > +++ b/drivers/hid/hid-apple.c
> > @@ -7,6 +7,7 @@
> >  *  Copyright (c) 2005 Michael Haboustak <mike-@xxxxxxxxxxxx> for Concept2, Inc
> >  *  Copyright (c) 2006-2007 Jiri Kosina
> >  *  Copyright (c) 2008 Jiri Slaby <jirislaby@xxxxxxxxx>
> > + *  Copyright (c) 2019 Paul Pawlowski <paul@xxxxxxxx>
> >  */
> > 
> > /*
> > @@ -33,6 +34,7 @@
> > /* BIT(7) reserved, was: APPLE_IGNORE_HIDINPUT */
> > #define APPLE_NUMLOCK_EMULATION	BIT(8)
> > #define APPLE_RDESC_BATTERY	BIT(9)
> > +#define APPLE_BACKLIGHT_CTL	0x0200
> Jiri, should it be BIT(10)? 0x0200 is BIT(9) if I ain’t wrong.

Yes, please use BIT(10). Thanks,

-- 
Jiri Kosina
SUSE Labs