Re: [PATCH] parport_pc: Also enable driver for PCI systems

From: Niklas Schnelle
Date: Mon Feb 14 2022 - 05:19:10 EST


On Mon, 2022-02-14 at 09:21 +0000, Maciej W. Rozycki wrote:
> On Mon, 14 Feb 2022, Niklas Schnelle wrote:
>
> > > > --- linux-macro.orig/drivers/parport/Kconfig
> > > > +++ linux-macro/drivers/parport/Kconfig
> > > > @@ -42,7 +42,7 @@ if PARPORT
> > > >
> > > > config PARPORT_PC
> > > > tristate "PC-style hardware"
> > > > - depends on ARCH_MIGHT_HAVE_PC_PARPORT
> > > > + depends on ARCH_MIGHT_HAVE_PC_PARPORT || PCI
> >
> > This would allow selecting PARPORT_PC on s390 e.g. for allyesconfig and
> > randconfig and like POWER9 we definitely do not support I/O port
> > access.
>
> I guess we'll have to stop it with !S390 then short-term. I don't think
> an issue with s390 should be blocking all the other platforms that can use
> these drivers just fine. I'll post v2 with that installed if you agree.
>
> Maciej

Though a bit ugly that sounds fine by me. Thanks.