RE: [PATCH v6 0/5] Add driver for GSC controller

From: Usyskin, Alexander
Date: Sun Feb 13 2022 - 05:03:50 EST




> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Sunday, February 13, 2022 11:56
> To: Usyskin, Alexander <alexander.usyskin@xxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Joonas Lahtinen
> <joonas.lahtinen@xxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>;
> David Airlie <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Winkler,
> Tomas <tomas.winkler@xxxxxxxxx>; Lubart, Vitaly <vitaly.lubart@xxxxxxxxx>;
> intel-gfx@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 0/5] Add driver for GSC controller
>
> On Sun, Feb 13, 2022 at 11:14:53AM +0200, Alexander Usyskin wrote:
> > GSC is a graphics system controller, it provides
> > a chassis controller for graphics discrete cards.
> >
> > There are two MEI interfaces in GSC: HECI1 and HECI2.
> >
> > This series includes instantiation of the auxiliary devices for HECI2
> > and mei-gsc auxiliary device driver that binds to the auxiliary device.
> >
> > In v2 the platform device was replaced by the auxiliary device.
> > v3 is the rebase over drm-tip to make public CI running.
> > In v4 the not needed debug prints and empty line were removed,
> > 'select' were replaced by 'depends on' in MEI Kconfig,
> > the new include file now listed in the MAINTATINERS file.
> > V5, rebase and add Greg KH Reviewed-by
> > V6, rebase and drop redundant assignments found by the kernel test
> robot.
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> This line needs to be added to the individual patches if you want any
> tool or maintainer to pick that up.
>

Thanks for a tip, will send with your review added to the individual patches.

> thanks,
>
> greg k-h