Re: [PATCH v2 00/10] random: re-group and re-document functions

From: Dominik Brodowski
Date: Sun Feb 13 2022 - 01:57:24 EST


Am Sat, Feb 12, 2022 at 01:23:08PM +0100 schrieb Jason A. Donenfeld:
> We previously had massive documentation comments and functions strewn
> all about. This attempts to restore sanity by dividing the code into a
> few sections:
>
> - Initialization and readiness waiting.
> - Fast key erasure RNG.
> - Entropy accumulation and extraction.
> - Entropy collection.
> - Userspace read/write.
> - Sysctl.
>
> The result of this ordering and this grouping is only 2 forward
> declarations, indicating that this is probably a sensible grouping.
> Also, some documentation that was just hopelessly out of date been
> removed. We'll later look into re-adding parts of this to the Linux man
> pages project.
>
> No functional changes.

Hi Jason,

thanks for your massive patchset. While some of it was a bit tedious and
repetetive to review, feel free to add my

Reviewed-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

to patchs 1-3, 6 and 8-10. For patches 4, 5 and 7, I have some comments;
once addressed, feel free to add my reviewed-by tag to those as well.

Thanks,
Dominik