Re: [PATCH v4 1/2] leds: ktd20xx: Extension of the KTD20xx family of LED drivers from Kinetic

[Pavel Machek]

Hi!


> > +       struct device *dev = &chip->client->dev;
> > +       int ret;
> > +       unsigned int value;
> 
> Here and everywhere can you use reverse xmas tree ordering?
> 
>        struct device *dev = &chip->client->dev;
>        unsigned int value;
>        int ret;

Lets not ask people to do that.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature