Re: [PATCH 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices
From: kernel test robot
Date: Sat Feb 12 2022 - 05:40:07 EST
Hi "Maciej,
I love your patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on usb/usb-testing v5.17-rc3 next-20220211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Maciej-W-Rozycki/serial-8250-Correct-basic-issues-with-the-PCI-blacklist/20220212-164230
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20220212/202202121734.Zc1GlUwC-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/aa68e36c332457acb464b083c920d10f0e5a9865
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Maciej-W-Rozycki/serial-8250-Correct-basic-issues-with-the-PCI-blacklist/20220212-164230
git checkout aa68e36c332457acb464b083c920d10f0e5a9865
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/tty/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/tty/serial/8250/8250_pci.c:3522:9: error: initializer element is not computable at load time
3522 | (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
| ^
drivers/tty/serial/8250/8250_pci.c:3535:39: note: in expansion of macro 'REPORT_CONFIG'
3535 | { PCI_DEVICE(0x4348, 0x7053), REPORT_CONFIG(PARPORT_SERIAL), },
| ^~~~~~~~~~~~~
drivers/tty/serial/8250/8250_pci.c:3522:9: note: (near initialization for 'blacklist[3].class')
3522 | (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
| ^
drivers/tty/serial/8250/8250_pci.c:3535:39: note: in expansion of macro 'REPORT_CONFIG'
3535 | { PCI_DEVICE(0x4348, 0x7053), REPORT_CONFIG(PARPORT_SERIAL), },
| ^~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_pci.c:3522:9: error: initializer element is not computable at load time
3522 | (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
| ^
drivers/tty/serial/8250/8250_pci.c:3537:39: note: in expansion of macro 'REPORT_CONFIG'
3537 | { PCI_DEVICE(0x4348, 0x5053), REPORT_CONFIG(PARPORT_SERIAL), },
| ^~~~~~~~~~~~~
drivers/tty/serial/8250/8250_pci.c:3522:9: note: (near initialization for 'blacklist[4].class')
3522 | (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
| ^
drivers/tty/serial/8250/8250_pci.c:3537:39: note: in expansion of macro 'REPORT_CONFIG'
3537 | { PCI_DEVICE(0x4348, 0x5053), REPORT_CONFIG(PARPORT_SERIAL), },
| ^~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_pci.c:3522:9: error: initializer element is not computable at load time
3522 | (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
| ^
drivers/tty/serial/8250/8250_pci.c:3539:39: note: in expansion of macro 'REPORT_CONFIG'
3539 | { PCI_DEVICE(0x1c00, 0x3250), REPORT_CONFIG(PARPORT_SERIAL), },
| ^~~~~~~~~~~~~
drivers/tty/serial/8250/8250_pci.c:3522:9: note: (near initialization for 'blacklist[5].class')
3522 | (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
| ^
drivers/tty/serial/8250/8250_pci.c:3539:39: note: in expansion of macro 'REPORT_CONFIG'
3539 | { PCI_DEVICE(0x1c00, 0x3250), REPORT_CONFIG(PARPORT_SERIAL), },
| ^~~~~~~~~~~~~
vim +3522 drivers/tty/serial/8250/8250_pci.c
3520
3521 #define REPORT_CONFIG(option) \
> 3522 (IS_ENABLED(CONFIG_##option) ? 0 : (kernel_ulong_t)&#option)
3523 #define REPORT_8250_CONFIG(option) \
3524 (IS_ENABLED(CONFIG_SERIAL_8250_##option) ? \
3525 0 : (kernel_ulong_t)&"SERIAL_8250_"#option)
3526
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx