Re: [RESEND v2 1/2] power: supply: Introduces bypass charging property

[Rivera-Matos, Ricardo]

Sebastian,

> On Feb 11, 2022, at 2:43 PM, Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote:
> 
> Hi,
> 
> On Thu, Feb 10, 2022 at 09:41:07AM -0600, Ricardo Rivera-Matos wrote:
>> Adds a POWER_SUPPLY_CHARGE_TYPE_BYPASS option to the POWER_SUPPLY_PROP_CHARGE_TYPE
>> property to facilitate bypass charging operation.
>> 
>> In bypass charging operation, the charger bypasses the charging path around the
>> integrated converter allowing for a "smart" wall adaptor to perform the power
>> conversion externally.
>> 
>> This operational mode is critical for the USB PPS standard of power adaptors and is
>> becoming a common feature in modern charging ICs such as:
>> 
>> - BQ25980
>> - BQ25975
>> - BQ25960
>> - LN8000
>> - LN8410
>> 
>> Signed-off-by: Ricardo Rivera-Matos <rriveram@xxxxxxxxxxxxxxxxxxxxx>
>> ---
> 
> Sorry for the wait. This needs to update the sysfs ABI documentation:
> 
> Documentation/ABI/testing/sysfs-class-power

Ack
> 
> I think your patch description is a good explanation for that file.
> Also I obviously missed to point this out for the "Long Life" charge
> type, so please also add a sentence for that so that the property
> is properly documented.

As I understand it “Long Life” means the charger reduces its charging rate in order to prolong the battery health.

Is this a fit explanation?
> 
> (Otherwise the patchset looks fine to me)
> 
> Thanks,
> 
> -- Sebastian

Best Regards,
Ricardo

<snip>