Re: [PATCH 20/75] mm/gup: Convert gup_pte_range() to use a folio

[Matthew Wilcox]

On Sun, Feb 06, 2022 at 02:52:46PM +0000, Mark Hemment wrote:
> On Fri, 4 Feb 2022 at 20:21, Matthew Wilcox (Oracle)
> <willy@xxxxxxxxxxxxx> wrote:
> V. Minor/nit: Above the "goto pte_unmap;" is the code block;
>            if (flags & FOLL_PIN) {
>                         ret = arch_make_page_accessible(page);
>                         if (ret) {
>                                 unpin_user_page(page);
>                                 goto pte_unmap;
>                         }
>                 }
> Other conditions which goto pte_unmap, after successful
> try_grab_folio(), call gup_put_folio() (rather than
> unpin_user_page()).
> No change in functionality, but suggest calling gup_put_folio() here
> too for consistency.

Thanks!  Changed.