Re: [PATCH v3 10/22] perf map: Make map__contains_symbol args const

From: Arnaldo Carvalho de Melo
Date: Fri Feb 11 2022 - 12:29:10 EST


Em Fri, Feb 11, 2022 at 02:34:03AM -0800, Ian Rogers escreveu:
> Now unmap_ip is const, make contains symbol const.

Not applying, waiting for a refresh of this patch set after the subset
that has been applied.

- Arnaldo

> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/util/map.c | 2 +-
> tools/perf/util/map.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index b98fb000eb5c..8bbf9246a3cf 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -516,7 +516,7 @@ u64 map__objdump_2mem(struct map *map, u64 ip)
> return ip + map->reloc;
> }
>
> -bool map__contains_symbol(struct map *map, struct symbol *sym)
> +bool map__contains_symbol(const struct map *map, const struct symbol *sym)
> {
> u64 ip = map->unmap_ip(map, sym->start);
>
> diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h
> index 212a9468d5e1..3dcfe06db6b3 100644
> --- a/tools/perf/util/map.h
> +++ b/tools/perf/util/map.h
> @@ -152,7 +152,7 @@ static inline bool __map__is_kmodule(const struct map *map)
>
> bool map__has_symbols(const struct map *map);
>
> -bool map__contains_symbol(struct map *map, struct symbol *sym);
> +bool map__contains_symbol(const struct map *map, const struct symbol *sym);
>
> #define ENTRY_TRAMPOLINE_NAME "__entry_SYSCALL_64_trampoline"
>
> --
> 2.35.1.265.g69c8d7142f-goog

--

- Arnaldo