Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

From: Wolfram Sang
Date: Thu Feb 10 2022 - 17:09:32 EST


On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:
> Implement an I2C controller sharing mechanism between the host (kernel)
> and PSP co-processor on some platforms equipped with AMD Cezanne SoC.
>
> On these platforms we need to implement "software" i2c arbitration.
> Default arbitration owner is PSP and kernel asks for acquire as well
> as inform about release of the i2c bus via mailbox mechanism.
>
> +---------+
> <- ACQUIRE | |
> +---------| CPU |\
> | | | \ +----------+ SDA

Applied to for-next, thanks! I fixed the following checkpatch warnings:

CHECK: Please don't use multiple blank lines
#232: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:92:
+
+

WARNING: braces {} are not necessary for single statement blocks
#361: FILE: drivers/i2c/busses/i2c-designware-amdpsp.c:221:
+ if (ret) {
+ goto cleanup;
+ }

Please also use checkpatch next time.

Attachment: signature.asc
Description: PGP signature