Re: [PATCH 01/23] KVM: MMU: pass uses_nx directly to reset_shadow_zero_bits_mask

From: Paolo Bonzini
Date: Thu Feb 10 2022 - 11:38:33 EST


On 2/10/22 01:30, Sean Christopherson wrote:
There may not be a functional change, but it drops an optimization and contributes
to making future code/patches more fragile due to making it harder to understand
the relationship between shadow_mmu_init_context() and __kvm_mmu_new_pgd().

Fair enough, I'll drop this patch.

Regarding the relationship between shadow_mmu_init_context() and kvm_mmu_new_pgd(), it's a lot more subtle than it looks. Please take a look first at the optimization series, since it removes that subtlety.

Paolo