Re: [PATCH] usbip: vudc: Make use of the helper macro LIST_HEAD()

[Shuah Khan]

On 2/9/22 7:37 PM, Cai Huoqing wrote:
> On 09 2月 22 09:00:37, Shuah Khan wrote:
> > On 2/8/22 8:28 PM, Cai Huoqing wrote:
> > > Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> > > "LIST_HEAD(head)" to simplify the code.
> > >
> > > Signed-off-by: Cai Huoqing <cai.huoqing@xxxxxxxxx>
> > > ---
> > >    drivers/usb/usbip/vudc_main.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/usbip/vudc_main.c b/drivers/usb/usbip/vudc_main.c
> > > index 678faa82598c..d43252b77efd 100644
> > > --- a/drivers/usb/usbip/vudc_main.c
> > > +++ b/drivers/usb/usbip/vudc_main.c
> > > @@ -26,7 +26,7 @@ static struct platform_driver vudc_driver = {
> > >    	},
> > >    };
> > > -static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices);
> > > +static LIST_HEAD(vudc_devices);
> > >    static int __init init(void)
> > >    {
> >
> > Explain why this change simplifies the code and also add a comment
> > above LIST_HEAD
> LIST_HEAD() help to clean up the code "struct list_head vudc_devices =
> ". we only to care the variable 'vudc_devices',
> >

How does LIST_HEAD() make it simpler. It does that I am sure. I am looking
for you to explain how it does in the change log.

thanks,
-- Shuah