Re: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291

From: Michael Walle
Date: Thu Feb 10 2022 - 08:34:03 EST


Am 2022-02-10 14:02, schrieb Kavyasree.Kotagiri@xxxxxxxxxxxxx:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe

Hi,

> arch/arm/boot/dts/Makefile | 2 +
> arch/arm/boot/dts/lan966x.dtsi | 237 ++++++++++++++++++++++++++
> arch/arm/boot/dts/lan966x_pcb8291.dts | 61 +++++++

Please rename this to lan966x-pcb8921.dts. All (most?) of the device
tree files use the dash as a seperator between the SoC and the board.

Ok, I will change in my v6.
Please have a look at my v5 patch where I already addressed all the
node naming changes.

My comments besides the renaming still apply.

-michael