Re: [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls

[Rui Miguel Silva]

Hey Minghao,
Many thanks for the patch.

On Thu Feb 10, 2022 at 6:02 AM WET,  wrote:

> From: Minghao Chi (CGEL ZTE) <chi.minghao@xxxxxxxxxx>
>
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@xxxxxxxxxx>

LGTM.
Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>

Cheers,
     Rui

> ---
>  drivers/staging/greybus/sdio.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 37bf04c22dbc..25bee5335c70 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -858,7 +858,6 @@ static void gb_sdio_remove(struct gbphy_device *gbphy_dev)
>  	gb_connection_set_data(connection, NULL);
>  	mutex_unlock(&host->lock);
>  
> -	flush_workqueue(host->mrq_workqueue);
>  	destroy_workqueue(host->mrq_workqueue);
>  	gb_connection_disable_rx(connection);
>  	mmc_remove_host(mmc);
> -- 
> 2.25.1