Re: [PATCH v5 6/7] thermal: netlink: Add a new event to notify CPU capabilities change

[Lukasz Luba]

On 1/30/22 3:20 PM, Rafael J. Wysocki wrote:
> On Thu, Jan 27, 2022 at 8:33 PM Ricardo Neri
> <ricardo.neri-calderon@xxxxxxxxxxxxxxx> wrote:
> > From: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> >
> > Add a new netlink event to notify change in CPU capabilities in terms of
> > performance and efficiency.
> >
> > Firmware may change CPU capabilities as a result of thermal events in the
> > system or to account for changes in the TDP (thermal design power) level.
> >
> > This notification type will allow user space to avoid running workloads
> > on certain CPUs or proactively adjust power limits to avoid future events.
> >
> > The netlink message consists of a nested attribute
> > (THERMAL_GENL_ATTR_CPU_CAPABILITY) with three attributes:
> >
> >   * THERMAL_GENL_ATTR_CPU_CAPABILITY_ID (type u32):
> >     -- logical CPU number
> >   * THERMAL_GENL_ATTR_CPU_CAPABILITY_PERFORMANCE (type u32):
> >     -- Scaled performance from 0-1023
> >   * THERMAL_GENL_ATTR_CPU_CAPABILITY_EFFICIENCY (type u32):
> >     -- Scaled efficiency from 0-1023
> >
> > Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > Cc: Aubrey Li <aubrey.li@xxxxxxxxxxxxxxx>
> > Cc: Lukasz Luba <lukasz.luba@xxxxxxx>
> > Cc: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> > Cc: "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>
> > Reviewed-by: Len Brown <len.brown@xxxxxxxxx>
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>
> Daniel, Lukasz, if you have any comments or concerns regarding this
> patch, please let me know.

My apologies Rafael, I missed that email.

I've looked at the patches 6/7 and 7/7 and they look OK with the
scaling.