Re: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board pcb8291

[Michael Walle]

Am 2022-02-10 10:40, schrieb Kavyasree.Kotagiri@xxxxxxxxxxxxx:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> > the
> > content is safe

> > > +     clocks {
> > [..]
> > > +
> > > +             nic_clk: nic_clk {
> >
> > What does nic_clk stand for? If I had to guess, it
> > has something to do with network. But..
> NIC clock is the clock used by AXI, AHB fabric and APB bridges which
> connects all the peripherals.
> It is named so because the AXI fabric is based on NIC400 IP from ARM

Ok, thanks for clarification.


> > > +             watchdog: watchdog@e0090000 {
> > > +                     compatible = "snps,dw-wdt";
> > > +                     reg = <0xe0090000 0x1000>;
> > > +                     interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> > > +                     clocks = <&nic_clk>;
> >
> > Btw. can we disable all nodes by default and enable them
> > in the board dts files?
> I would like to have only board specific nodes enabled in dts files
> and rest of them in dtsi file

And how do you know which ones are board specific? E.g. I would like
to add our board which is also based on the lan9668. Maybe I don't
want a watchdog (or whatever node). Of course I could use

&watchdog {
  status = "disabled";
};

But IMHO opt-in is better. At least thats what we are doing for
the layerscape over on arm64.

-michael