Re: [PATCH][next] brcmfmac: p2p: Replace one-element arrays with flexible-array members

From: Kalle Valo
Date: Thu Feb 10 2022 - 03:46:35 EST


"Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx> wrote:

> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of one-element or zero-length arrays should no longer be used[2].
>
> This helps with the ongoing efforts to globally enable -Warray-bounds
> and get us closer to being able to tighten the FORTIFY_SOURCE routines
> on memcpy().
>
> This issue was found with the help of Coccinelle and audited and fixed,
> manually.
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/79
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

f3c04fffe271 brcmfmac: p2p: Replace one-element arrays with flexible-array members

--
https://patchwork.kernel.org/project/linux-wireless/patch/20220204232228.GA442895@embeddedor/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches