Re: [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014

From: Nuno Sá
Date: Thu Feb 10 2022 - 03:26:29 EST


On Wed, 2022-02-09 at 14:01 +0200, Andy Shevchenko wrote:
> On Mon, Feb 07, 2022 at 09:29:54PM +0100, Nuno Sá wrote:
> > On Sat, 2022-02-05 at 20:23 +0200, Andy Shevchenko wrote:
> > > On Mon, Jan 31, 2022 at 12:00:59PM +0200, Antoniu Miclaus wrote:
> > > > The ADMV1014 is a silicon germanium (SiGe), wideband,
> > > > microwave downconverter optimized for point to point microwave
> > > > radio designs operating in the 24 GHz to 44 GHz frequency
> > > > range.
> > >
> > > Excellent job!
> > > A few comments / questions below.
> > >
> > > ...
> > >
> > > > +config ADMV1014
> > > > +       tristate "Analog Devices ADMV1014 Microwave
> > > > Downconverter"
> > > > +       depends on SPI && COMMON_CLK && 64BIT
> > >
> > > Why 64BIT only?
> >
> > Could not resist on this one... The thing is that CCF uses unsigned
> > long for rates and this part operates in high GHz values. That
> > means,
> > as CCF stands, this cannot work on 32bit.
>
> I read it a bit differently, i.e. CCF has a bug that needs to be
> addressed.
>

Totally agreed...

However, this can be something that might take time
to support in CCF (I definetly have plans to send a RFC to, at least,
start the discussion around this) so I guess we can already support
this device like this. I believe this is somethig straight to remove
as soon as CCF works in 32bit archs for high speed devices...

- Nuno Sá