Re: [PATCH v1 02/14] mtd: spi-nor: slightly refactor the spi_nor_setup()

[Tudor.Ambarus]

On 2/10/22 10:01, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Am 2022-02-10 04:00, schrieb Tudor.Ambarus@xxxxxxxxxxxxx:
>> On 2/2/22 16:58, Michael Walle wrote:

cut

>>> Also mark the parameter as optional now.

Oh, I misread, in my head I read "for now". That's why I asked what should
be done next :).
>>
>> what should be done in the future?
> 
> What do you mean? IMHO the default path should be visible in the
> function. Eg.
> 
> int spi_nor_bla(nor) {
>     if (nor->some_exceptional_cb)
>         return nor->some_exceptional_cb(nor);
> 
>    return usual_cb(nor);
> }
> 
> -michael