RE: [RFC 2/2] PCI: imx6: Enable imx6qp pcie power management support

[Hongxing Zhu]

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Sent: 2022年2月9日 23:37
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: l.stach@xxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx;
> lorenzo.pieralisi@xxxxxxx; shawnguo@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [RFC 2/2] PCI: imx6: Enable imx6qp pcie power management
> support
> 
> In subject, s/pcie/PCIe/ or remove it altogether, since I don't think it adds
> useful information.
> 
> On Wed, Feb 09, 2022 at 03:02:36PM +0800, Richard Zhu wrote:
> > i.MX6QP PCIe supports the RESET logic, thus it can support the L2 exit
> > by the reset mechanism.
> > Enable the i.MX6QP PCIe suspend/resume operations support.
> 
> Add blank line between paragraphs or rewrap into a single paragraph.
Got that, thanks.

> 
> Rewrap to fill 75 columns.
Okay, would be changed.

> 
> What does "L2 exit by reset mechanism" mean?  Is this an i.MX6-specific
> thing?  If not, can you point me to the relevant part of the PCIe spec?
No, it's not i.MX6 specific thing. i.MX6Q/DL doesn't have the self-reset mechanism.
Thus, it can't reset itself to an initialized stat when link exit from the L2
or L3 stats.
i.MX6QP PCIe has the self-reset mechanism, and it can reset itself when link
exit from L2 or L3 stats.
The commit description might not accurate.
How about change them to "i.MX6QP PCIe supports the RESET logic, thus it can
 reset itself to the initialized stat when exit from L2 or L3 stats."

Best Regards
Richard Zhu
> 
> Bjorn