Re: [PATCH 5/5] arm64: dts: ti: Add support for AM62-SK

[Vignesh Raghavendra]

On 08/02/22 10:38 pm, Krzysztof Kozlowski wrote:
> On 08/02/2022 14:18, Vignesh Raghavendra wrote:
>> From: Nishanth Menon <nm@xxxxxx>
>>
[...]
>> +	vmain_pd: fixed-regulator-vmain-pd {
>> +		/* TPS65988 PD CONTROLLER OUTPUT */
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vmain_pd";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +	};
>> +
>> +	vcc_5v0: fixedregulator-vcc5v0 {
>> +		/* Output of LM34936 */
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc_5v0";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		vin-supply = <&vmain_pd>;
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +	};
>> +
>> +	vcc_3v3_sys: fixedregulator-vcc-3v3-sys {
> 
> Generic node names (as in DT spec), so regulator-[0-9]. The label and
> regulator-name property describe it's user-friendly purpose.

Ah, yes, missed it, will fix in v2

Thanks for the review!

Regards
Vignesh