Re: [PATCH 1/2] regulator: Add bindings for TPS62864x

[Rob Herring]

On Fri, Feb 04, 2022 at 04:52:40PM +0100, Vincent Whitchurch wrote:
> Add bindings for the TPS62864/TPS6286/TPS62868/TPS62869 voltage
> regulators.
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> ---
>  .../bindings/regulator/ti,tps62864.yaml       | 62 +++++++++++++++++++
>  include/dt-bindings/regulator/ti,tps62864.h   |  9 +++
>  2 files changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
>  create mode 100644 include/dt-bindings/regulator/ti,tps62864.h
> 
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
> new file mode 100644
> index 000000000000..e3d739a37ab0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,tps62864.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TPS62864/TPS6286/TPS62868/TPS62869 voltage regulator
> +
> +maintainers:
> +  - Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tps62864
> +      - ti,tps62866
> +      - ti,tps62868
> +      - ti,tps62869
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +
> +    patternProperties:
> +      "SW":

Not a pattern, use 'properties'. Actually it is a pattern, so 'fooSWbar' 
would be a valid node name.

> +        type: object
> +        $ref: regulator.yaml#

           unevaluatedProperties: false

> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - regulators
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/regulator/ti,tps62864.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      regulator@48 {
> +        compatible = "ti,tps62864";
> +        reg = <0x48>;
> +
> +        regulators {
> +          SW {
> +            regulator-name = "+0.85V";
> +            regulator-min-microvolt = <800000>;
> +            regulator-max-microvolt = <890000>;
> +            regulator-initial-mode = <TPS62864_MODE_FPWM>;
> +          };
> +        };
> +      };
> +    };
> +
> +...
> diff --git a/include/dt-bindings/regulator/ti,tps62864.h b/include/dt-bindings/regulator/ti,tps62864.h
> new file mode 100644
> index 000000000000..8db31f23d956
> --- /dev/null
> +++ b/include/dt-bindings/regulator/ti,tps62864.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#ifndef _DT_BINDINGS_REGULATOR_TI_TPS62864_H
> +#define _DT_BINDINGS_REGULATOR_TI_TPS62864_H
> +
> +#define TPS62864_MODE_NORMAL			0
> +#define TPS62864_MODE_FPWM			1
> +
> +#endif
> -- 
> 2.34.1
> 
>