Re: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support

From: Javier Martinez Canillas
Date: Wed Feb 09 2022 - 07:41:28 EST


Hello Geert,

Thanks for your feedback.

On 2/9/22 13:21, Geert Uytterhoeven wrote:

[snip]

>
>> +static const struct of_device_id ssd130x_of_match[] = {
>> + {
>> + .compatible = "solomon,ssd1305fb-i2c",
>> + .data = (void *)&ssd130x_ssd1305_deviceinfo,
>
> The casts are not needed.
>

Right. I copied the table from the ssd1307fb driver verbatim. I'll clean it up.

Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat