[PATCH] power: supply: da9150: use div64_u64() instead of do_div()

From: Qing Wang
Date: Wed Feb 09 2022 - 03:40:50 EST


From: Wang Qing <wangqing@xxxxxxxx>

do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
---
drivers/power/supply/da9150-fg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
index 6e36782..896491a
--- a/drivers/power/supply/da9150-fg.c
+++ b/drivers/power/supply/da9150-fg.c
@@ -250,7 +250,7 @@ static int da9150_fg_current_avg(struct da9150_fg *fg,
div = (u64) (sd_gain * shunt_val * 65536ULL);
do_div(div, 1000000);
res = (u64) (iavg * 1000000ULL);
- do_div(res, div);
+ div64_u64(res, div);

val->intval = (int) res;

--
2.7.4