RE: [PATCH] can: xilinx_can: Add check for NAPI Poll function

From: Srinivas Neeli
Date: Wed Feb 09 2022 - 03:30:04 EST


Hi Marc,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: Wednesday, February 9, 2022 1:20 PM
> To: Srinivas Neeli <sneeli@xxxxxxxxxx>
> Cc: wg@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; Michal
> Simek <michals@xxxxxxxxxx>; linux-can@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Appana Durga Kedareswara Rao
> <appanad@xxxxxxxxxx>; Srinivas Goud <sgoud@xxxxxxxxxx>; git
> <git@xxxxxxxxxx>
> Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function
>
> On 08.02.2022 21:50:53, Srinivas Neeli wrote:
> > Add check for NAPI poll function to avoid enabling interrupts with out
> > completing the NAPI call.
>
> Thanks for the patch. Does this fix a bug? If so, please add a Fixes:
> tag that lists the patch that introduced that bug.

It is not a bug. I am adding additional safety check( Validating the return value of "napi_complete_done" call).

Thanks
Srinivas Neeli

>
> regards,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |