Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication

From: Takashi Iwai
Date: Wed Feb 09 2022 - 02:09:31 EST


On Wed, 09 Feb 2022 05:23:23 +0100,
Mohan Kumar wrote:
>
> --- a/include/sound/hda_codec.h
> +++ b/include/sound/hda_codec.h
> @@ -240,6 +240,10 @@ struct hda_codec {
> unsigned int single_adc_amp:1; /* adc in-amp takes no index
> * (e.g. CX20549 codec)
> */
> + unsigned int hdmi_intr_trig_ctrl:1; /* hdmi interrupt trigger
> + * control flag
> + * (e.g. Nvidia codecs)
> + */

This flag is specific to (Nvidia) HDMI codec and referred only from
patch_hdmi.c, right? If so, the flag would be better put locally to
struct hdmi_spec instead of a global hda_codec.


thanks,

Takashi