Re: [PATCH v8 net-next 03/10] net: phy: Add support for LAN937x T1 phy driver

[Andrew Lunn]

On Mon, Feb 07, 2022 at 10:51:57PM +0530, Prasanna Vengateshan wrote:
> Added support for Microchip LAN937x T1 phy driver. The sequence of
> initialization is used commonly for both LAN87xx and LAN937x
> drivers. The new initialization sequence is an improvement to
> existing LAN87xx and it is shared with LAN937x.
> 
> Also relevant comments are added in the existing code and existing
> soft-reset customized code has been replaced with
> genphy_soft_reset().
> 
> access_ereg_clr_poll_timeout() API is introduced for polling phy
> bank write and this is linked with PHYACC_ATTR_MODE_POLL.
> 
> Finally introduced function table for LAN937X_T1_PHY_ID along with
> microchip_t1_phy_driver struct.

Hi Prasanna

That is a lot of changes in one patch.

I would suggest you make this a patch series of its own. It should be
independent of the switch changes. And then you can break this patch
up into a number of smaller patches.

Thanks
	Andrew