RE: [PATCH] Add check for READ ONLY flag

[Dikshita Agarwal (QUIC)]

Thanks Hans for review.
I sent a v2 addressing it.

Thanks,
Dikshita Agarwal

-----Original Message-----
From: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> 
Sent: Tuesday, February 08, 2022 6:10 PM
To: Dikshita Agarwal (QUIC) <quic_dikshita@xxxxxxxxxxx>
Cc: linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; vgarodia@xxxxxxxxxxxxxx
Subject: Re: [PATCH] Add check for READ ONLY flag

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

On 2/4/22 07:47, Dikshita Agarwal wrote:
> Add a check for V4L2_CTRL_FLAG_READ_ONLY to avoid request testing for 
> such controls.

Missing Signed-off-by!

Regards,

        Hans

> ---
>  utils/v4l2-compliance/v4l2-test-buffers.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/utils/v4l2-compliance/v4l2-test-buffers.cpp 
> b/utils/v4l2-compliance/v4l2-test-buffers.cpp
> index fa8c37c..b8de7af 100644
> --- a/utils/v4l2-compliance/v4l2-test-buffers.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-buffers.cpp
> @@ -2032,7 +2032,8 @@ int testRequests(struct node *node, bool test_streaming)
>               if (qctrl.type != V4L2_CTRL_TYPE_INTEGER &&
>                   qctrl.type != V4L2_CTRL_TYPE_BOOLEAN)
>                       continue;
> -             if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY)
> +             if (qctrl.flags & V4L2_CTRL_FLAG_WRITE_ONLY ||
> +                 qctrl.flags & V4L2_CTRL_FLAG_READ_ONLY)
>                       continue;
>               if (is_vivid && V4L2_CTRL_ID2WHICH(qctrl.id) == V4L2_CTRL_CLASS_VIVID)
>                       continue;