Re: [PATCH] PCI: endpoint fix misused goto label

[Kishon Vijay Abraham I]

On 21/01/22 1:18 pm, Li Chen wrote:
> From: Li Chen <lchen@xxxxxxxxxxxxx>
> 
> If we goto err_map_addr here, buf allocated
> via kmalloc won't get freeed, then memoryleak.
> 
> Signed-off-by: Li Chen <lchen@xxxxxxxxxxxxx>

Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 96489cfdf58db..60303223976a1 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -441,7 +441,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test)
>  		if (!epf_test->dma_supported) {
>  			dev_err(dev, "Cannot transfer data using DMA\n");
>  			ret = -EINVAL;
> -			goto err_map_addr;
> +			goto err_dma_map;
>  		}
>  
>  		src_phys_addr = dma_map_single(dma_dev, buf, reg->size,
>