Re: [PATCH V6 1/3] platform/x86: Add Intel Software Defined Silicon driver

[David E. Box]

On Mon, 2022-02-07 at 21:34 -0800, Joe Perches wrote:
> On Mon, 2022-02-07 at 18:54 -0800, David E. Box wrote:
> > On Mon, 2022-02-07 at 17:40 -0800, Joe Perches wrote:
> > > On Mon, 2022-02-07 at 16:54 -0800, David E. Box wrote:
> > > > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism
> > > > for
> > > > activating additional silicon features. Features are enabled through a
> > > > license activation process.  The SDSi driver provides a per socket,
> > > > sysfs
> > > > attribute interface for applications to perform 3 main provisioning
> > > > functions:
> []
> > > > +static int sdsi_mbox_cmd_read(struct sdsi_priv *priv, struct
> > > > sdsi_mbox_info
> > > > *info,
> > > > +			      size_t *data_size)
> > > > +{
> > > > +	struct device *dev = priv->dev;
> > > > +	u32 total, loop, eom, status, message_size;
> > > []
> > > > +		if (packet_size > SDSI_SIZE_MAILBOX) {
> > > > +			dev_err(dev, "Packet size to large\n");
> > > 
> > > too
> > 
> > Sorry, I'm missing the question here. If it's whether packet_size could also
> > not
> > be a multiple of sizeof(u64) the answer here is yes. But I don't see how
> > that
> > matters. packet_size is a value read from the hardware. This is just a
> > sanity
> > check.
> 
> just a to/too typo.
> 
> "Packet size too large\n"

Doh!

> 
>