Re: [PATCH v1] Documentation: KUnit: Fix usage bug

From: Brendan Higgins
Date: Mon Feb 07 2022 - 15:48:07 EST


On Mon, Feb 7, 2022 at 6:21 AM Akira Kawata <akirakawata1@xxxxxxxxx> wrote:
>
> Fix a bug of kunit documentation.
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205773
>
> : Quoting Steve Pfetsch:
> :
> : kunit documentation is incorrect:
> : https://kunit.dev/third_party/stable_kernel/docs/usage.html
> : struct rectangle *self = container_of(this, struct shape, parent);
> :
> :
> : Shouldn't it be:
> : struct rectangle *self = container_of(this, struct rectangle, parent);
> : ?
>
> Signed-off-by: Akira Kawata <akirakawata1@xxxxxxxxx>

Wow. I can't believe we let this go for this long...and even after
doing an *almost* complete rewrite of that page.

Anyway, thanks for fixing this!

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>