5.17-rc regression: X1 Carbon touchpad not resumed

From: Hugh Dickins
Date: Mon Feb 07 2022 - 14:49:32 EST


5.17-rc[1-3] on Lenovo ThinkPad X1 Carbon 5th gen: when lid closed
and opened and system resumed, the touchpad cursor cannot be moved.

Some dmesg from bootup:
[ 2.211061] rmi4_smbus 6-002c: registering SMbus-connected sensor
[ 2.263809] ucsi_acpi USBC000:00: UCSI_GET_PDOS failed (-95)
[ 2.291782] rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3289-002, fw id: 2492434
[ 2.371377] input: Synaptics TM3289-002 as /devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00/input/input8
[ 2.380820] serio: RMI4 PS/2 pass-through port at rmi4-00.fn03
...
[ 2.725471] input: PS/2 Generic Mouse as /devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00/rmi4-00.fn03/serio2/input/input9

Some dmesg from resume:
[ 79.221064] rmi4_smbus 6-002c: failed to get SMBus version number!
[ 79.265074] rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read current IRQ mask.
[ 79.308330] rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -6.
[ 79.308335] rmi4_f01 rmi4-00.fn01: Resume failed with code -6.
[ 79.308339] rmi4_physical rmi4-00: Failed to suspend functions: -6
[ 79.308342] rmi4_smbus 6-002c: Failed to resume device: -6
[ 79.351967] rmi4_physical rmi4-00: Failed to read irqs, code=-6

Bisection led to 172d931910e1db800f4e71e8ed92281b6f8c6ee2
("i2c: enable async suspend/resume on i2c client devices")
and reverting that fixes it for me.

Hugh