Re: [PATCH v2 1/2] MIPS: Loongson64: Clean up use of cc-ifversion

[Thomas Bogendoerfer]

On Tue, Jan 25, 2022 at 03:19:24PM -0700, Nathan Chancellor wrote:
> This Makefile checks that GCC is 4.9 or newer, which is redundant after
> commit 76ae847497bc ("Documentation: raise minimum supported version of
> GCC to 5.1"), so cc-option can be removed.
> 
> Clang does not support -march=loongson3a so it needs to continue to use
> -march=mips64r2, which no longer needs cc-option because all supported
> clang versions recognize this flag.
> 
> -march=loonson3a can be used unconditionally with GCC because the
> minimum supported GCC version has been bumped past 4.9.0, which won't
> have the bug mentioned in the comment. The _MIPS_ISA macro redefinition
> can be removed at the same time for the same reason.
> 
> Suggested-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> Suggested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> 
> v1 -> v2: https://lore.kernel.org/r/20220120214001.1879469-1-nathan@xxxxxxxxxx/
> 
> * Eliminate ld-option call (Jiaxun).
> * Eliminate _MIPS_ISA macro redefinitions (Nick).
> 
>  arch/mips/loongson64/Platform | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]