Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages

[Andy Shevchenko]

On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote:
> On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote:
> > In a couple of messages the constants, which have their definitions,
> > are hard coded into the message text. Unhardcode them.
> 
> Found by inspection or tool?

Does it matter? No, a side effect of the following patch.

...

> > +		dev_err(dev, "Steinhart sensors size(%zu) must be %d", new_custom->size,
> > +			LTC2983_CUSTOM_STEINHART_SIZE);
> 
> probably better using "%u" and not "%d"
> 
> and better with a \n termination too.

I think it would be a separate change if we wish so. Let Jonathan to tell what
to do here.

-- 
With Best Regards,
Andy Shevchenko