Re: [PATCH v7 01/17] KVM: s390: pv: leak the topmost page table when destroy fails

From: Heiko Carstens
Date: Mon Feb 07 2022 - 09:46:21 EST


> > + asce = (gmap->asce & ~PAGE_MASK) | __pa(table);
>
> Please add a comment:
> Set the new table origin while preserving ASCE control bits like table type
> and length.

And while touching this anyway, please make use of _ASCE_ORIGIN
instead of PAGE_MASK.