Re: [PATCH 1/2] i2c: hisi: Add generic GPIO bus recovery support

From: Andy Shevchenko
Date: Mon Feb 07 2022 - 06:26:28 EST


On Tue, Jan 25, 2022 at 08:49:29PM +0800, Yicong Yang wrote:
> Add generic GPIO bus recovery support for i2c-hisi driver
> by registering the recovery information with core provided
> i2c_generic_scl_recovery() method.
>
> As the SCL/SDA pins are multiplexed with GPIO, we need to
> switch the pins mux to GPIO before recovery and switch back
> after recovery. It's implemented by the ACPI method in
> the i2c_bus_recovery_info->{prepare,unprepare}_recovery()
> method.

NAK.

ACPI has its own resources for that. What is missed is the layer between ACPI
and pin control.

--
With Best Regards,
Andy Shevchenko