Re: [PATCH v3 3/6] rtc: sun6i: Enable the bus clock when provided

From: Maxime Ripard
Date: Mon Feb 07 2022 - 04:01:42 EST


On Wed, Feb 02, 2022 at 08:17:33PM -0600, Samuel Holland wrote:
> H6 and newer variants of the RTC hardware have a bus clock gate in the
> PRCM CCU. This was not known at the time H6 support was added, so it was
> not included in the H6 RTC binding, nor in the H6 PRCM CCU driver. Now
> that this clock gate is documented, it is included in the A100 and D1
> PRCM CCU drivers. Therefore, the RTC driver needs to have a consumer for
> the clock gate to prevent Linux from disabling it.
>
> Patch-changes: 3
> - New patch for compatibility with new CCU drivers

Did that creep in? Shouldn't it be in your changelog?

With that fixed,
Reviewed-by: Maxime Ripard <maxime@xxxxxxxxxx>

Maxime

Attachment: signature.asc
Description: PGP signature