[PATCH 2/2] drm/bridge: ti-sn65dsi83: Allow GPIO operations to sleep

From: Alexander Stein
Date: Mon Feb 07 2022 - 02:55:47 EST


There is no need to require non-sleeping GPIO access. Silence the
WARN_ON() if GPIO is using e.g. I2C expanders.

Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
---
If the GPIO is from an expander on I2C, this warning will rise
obviously. Straight forward fix.

drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 1f02596d6db4..2927fa2abd3d 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge,
}

/* Deassert reset */
- gpiod_set_value(ctx->enable_gpio, 1);
+ gpiod_set_value_cansleep(ctx->enable_gpio, 1);
usleep_range(1000, 1100);

/* Get the LVDS format from the bridge state. */
@@ -497,7 +497,7 @@ static void sn65dsi83_atomic_disable(struct drm_bridge *bridge,
int ret;

/* Put the chip in reset, pull EN line low, and assure 10ms reset low timing. */
- gpiod_set_value(ctx->enable_gpio, 0);
+ gpiod_set_value_cansleep(ctx->enable_gpio, 0);
usleep_range(10000, 11000);

ret = regulator_disable(ctx->vcc);
--
2.25.1