Re: [PATCH] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs

From: Pavel.Parkhomenko
Date: Sat Feb 05 2022 - 10:23:29 EST


On Fri, 04/02/2022 at 14:10 +0100, Andrew Lunn wrote:
> Hi Pavel
>
> There appears to be another path which has the same issue.
>
> m88e1118_config_aneg() calls marvell_set_polarity(), which also needs
> a reset afterwards.
>
> Could you fix this case as well?
>
> Thanks
>         Andrew

m88e1118_config_aneg() was added back in 2008 and has unconditional
genphy_soft_reset() at the very beginning. I haven't got 88E1118R or
88E11149R by the hand and the full documentation is also not available.
I believe that in this case it would be safe to still issue reset
unconditionally, but do it at the very end of m88e1118_config_aneg().
Anyways, I'd like to post it as a separate patch as I cannot test the fix
properly, unlike previous patch regarding 88E1510.

--
Best regards,
Pavel Parkhomenko