Re: [PATCH v3 2/4] clk: loongson1: Terminate clk_div_table with sentinel element

[Philippe Mathieu-Daudé]

On 5/2/22 01:52, Jonathan Neuschäfer wrote:
> In order that the end of a clk_div_table can be detected, it must be
> terminated with a sentinel element (.div = 0).
>
> Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>
> ---
>
> v3:
> - no changes
>
> v2:
> - Add Fixes and R-b tags
> ---
>   drivers/clk/loongson1/clk-loongson1c.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c
> index 703f87622cf5f..a6f9f20fc8b99 100644
> --- a/drivers/clk/loongson1/clk-loongson1c.c
> +++ b/drivers/clk/loongson1/clk-loongson1c.c
> @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = {
>   	[1] = { .val = 1, .div = 4 },
>   	[2] = { .val = 2, .div = 3 },
>   	[3] = { .val = 3, .div = 3 },
> +	[4] = { /* sentinel */ },

Sorry for being nitpicky here, but we don't need the trailing comma,
since this is the last entry.

>   };
>
>   void __init ls1x_clk_init(void)
> --
> 2.34.1