Re: [PATCH v3 4/4] clk: clps711x: Terminate clk_div_table with sentinel element

[Philippe Mathieu-Daudé]

On 5/2/22 01:52, Jonathan Neuschäfer wrote:
> In order that the end of a clk_div_table can be detected, it must be
> terminated with a sentinel element (.div = 0).
>
> Fixes: 631c53478973d ("clk: Add CLPS711X clk driver")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> ---
>
> v3:
> - no changes
>
> v2:
> - Add Fixes tag
> ---
>   drivers/clk/clk-clps711x.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/clk-clps711x.c b/drivers/clk/clk-clps711x.c
> index a2c6486ef1708..d96d96c8752c7 100644
> --- a/drivers/clk/clk-clps711x.c
> +++ b/drivers/clk/clk-clps711x.c
> @@ -28,11 +28,13 @@ static const struct clk_div_table spi_div_table[] = {
>   	{ .val = 1, .div = 8, },
>   	{ .val = 2, .div = 2, },
>   	{ .val = 3, .div = 1, },
> +	{}

Why not use the same style on all patches? Others developers looking
at this code will directly grab this is a sentinel section, instead of
wondering why this empty section is here.

        { /* sentinel */ }

Anyhow the patch logic is correct, so:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>

>   };
>
>   static const struct clk_div_table timer_div_table[] = {
>   	{ .val = 0, .div = 256, },
>   	{ .val = 1, .div = 1, },
> +	{}

(same comment)

>   };
>
>   struct clps711x_clk {
> --
> 2.34.1